Set DOTNET_CLI_HOME and NUGET_PACKAGES for helix work items #7292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexperovich
requested review from
dougbu,
HaoK,
ViktorHofer,
MattGal and
ChadNedzlek
MattGal
approved these changes
Apr 23, 2021
HaoK
approved these changes
Apr 23, 2021
dougbu
approved these changes
Apr 23, 2021
|
Hello @alexperovich! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
Unfortunately, once this goes in and reaches dotnet/aspnetcore, we should probably ignore the change. Too many tests expect the tools to be found in the current directory. Maybe we could bite the bullet but it's not as simple as changing a few lines in our Helix scripts and |
ghost
merged commit 
1 task
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting these variables adds more isolation for dotnet commands reducing the impact of machine wide problems.