Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor out the CoreCLR configuration detection so we can re-use it in dotnet/runtime without having to copy it. #8176

Merged
merged 2 commits into from
Nov 13, 2021
Merged

Refactor out the CoreCLR configuration detection so we can re-use it in dotnet/runtime without having to copy it. #8176

merged 2 commits into from
Nov 13, 2021

Conversation

jkoritzinsky
Copy link
Member

Based on feedback from dotnet/runtime#60846

To double check:

cc: @safern

@jkoritzinsky
Refactor out the CoreCLR configuration detection so we can re-use it …
792a009 
…in dotnet/runtime without having to copy it.
safern
safern approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jkoritzinsky jkoritzinsky merged commit 16988fc into dotnet:main Nov 13, 2021
@jkoritzinsky jkoritzinsky deleted the coreclr-configuration-detection branch November 13, 2021 21:58
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@safern safern safern approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkoritzinsky @safern