Fixup common templates to be compatible with devdiv pools #8371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In an earlier change, hosted pool usage was moved. This didn't account for differences in pools in devdiv and dnceng.
|
Ugh, this is really lame |
riarenas
approved these changes
Jan 21, 2022
No kidding. I thought I was home free. Then Matchell struck! |
|
WAT!? I literally did an official build with that above. What did I do. |
mmitche
added a commit
that referenced
this pull request
Jan 24, 2022
)" This reverts commit ece70e4.
|
Oh it's because the OneLocBuild job is conditionalized to not run. |
mmitche
added a commit
to mmitche/arcade
that referenced
this pull request
Jan 28, 2022
In an earlier change, hosted pool usage was moved. This didn't account for differences in pools in devdiv and dnceng.
mmitche
added a commit
that referenced
this pull request
Feb 2, 2022
* Revert "Revert "Streamline and simplify v3 publishing job"" (#8340) * Revert "Revert "Streamline and simplify v3 publishing job (#8334)" (#8339)" This reverts commit 7189b4a. * Remove parameter usage * Use 1ES pools in templates that run internally (#8344) * Use 1ES pools in templates that run internally - Use the 1ES pools in our templates, jobs, etc. - To reduce some of the cost of this, remove the "Setup Maestro Vars" job and replace with a step so that we don't end up with an additional allocation in those cases. - Call setup maestro vars to populate the azdo params in execute-sdl * Fix DevDiv promotion job (#8370) - Ensure devdiv promotion job uses devdiv pools - Use powershell core (the pools don't have IE initialized so we have to use basic parsing, which is default on powershell core) * Fixup common templates to be compatible with devdiv pools (#8371) In an earlier change, hosted pool usage was moved. This didn't account for differences in pools in devdiv and dnceng. * Fix oneloc template (#8381) The OneLoc template isn't used in the official build when not on main, so validation got skipped.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an earlier change, hosted pool usage was moved. This didn't account for differences in pools in devdiv and dnceng.
To double check: