Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate xunit reporter #7931

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Conversation

ChadNedzlek
Copy link
Member

@ChadNedzlek ChadNedzlek commented Sep 21, 2021

This code is already dead inside Helix... we no longer read the events this
reporter is sending, so it's just spending a bunch of time to send dead
events. I'm removing the code and having it send an obselete warning.

It also causes a workitem to be non-idepotent, because it uploads a file to a fixed
URI, and if a retry (infra, test, or otherwise) happens, the second upload crashes,
causing the workitem to fail.

This code is already dead inside Helix... we no longer read the events this
reporter is sending, so it's just spending a bunch of time to send dead
events.  I'm removing the code and having it send an obselete warning.
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found many more references of EnableXUnitReporter in this repo. Can you remove all?

@ChadNedzlek
Copy link
Member Author

@premun, sure... I'll see what I can find... why is one flag documented in multiple places... but I'll find them. :-)

@ChadNedzlek ChadNedzlek merged commit 27d2861 into dotnet:main Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants