Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workloads: Tooling changes to MSI and SWIX generation #7525

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jun 15, 2021

  • Add the generated MSI name to the JSON manifest for workload pack payload packages. This is required to ensure CLI caching understands potential name shortening to address VS caching issues with long paths.
  • Generate ComponentGroups for abstract workloads
  • Change SWIX dependency versions to be minimum only, with no upper bound, e.g. [4.0,)

@joeloff joeloff requested review from chcosta, dsplaisted and wli3 June 15, 2021 03:42
@joeloff
Copy link
Member Author

joeloff commented Jun 15, 2021

@mhutch FYI, this adds support to pull in abstract workloads as component group dependencies in the generated VS authoring

Copy link
Member

@chcosta chcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not my area of expertise, but assuming that this comment is true...

// Component dependencies, aka. workload extensions only have minimum version dependencies.

This change looks fine to me.

@joeloff
Copy link
Member Author

joeloff commented Jun 15, 2021

This is not my area of expertise, but assuming that this comment is true...

// Component dependencies, aka. workload extensions only have minimum version dependencies.

This change looks fine to me.

Thanks. The min version is generated here: https://github.com/dotnet/arcade/pull/7525/files#diff-7f2fc04667acd8fbeceaad29c0541da314469609b5f9fa717db903a91fdbfaf2R142

Setting max version to null, generates something like [1.2.0,) in the SWIX files

@joeloff joeloff merged commit 12956a1 into dotnet:main Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants