Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable or disable telemetry #7638

Merged
19 commits merged into from
Jul 20, 2021
Merged

Enable or disable telemetry #7638

19 commits merged into from
Jul 20, 2021

Conversation

epananth
Copy link
Member

To double check:

Added ability to turn off telemetry in Telemetry.cs

was able to test this in release pipeline -> https://dnceng.visualstudio.com/internal/_build/results?buildId=1241503&view=logs&j=d7f318d2-3658-5f56-29df-16b211ec56a6&t=7851342b-b7f6-561e-0dbe-e63708dfa83e

Copy link
Contributor

@michellemcdaniel michellemcdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this, but make sure Chris gets a chance to review

@epananth
Copy link
Member Author

@chcosta can you please take a look at this before I merge this change?

Copy link
Member

@chcosta chcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the "true" explicit check and this LGTM

@epananth epananth added the auto-merge Automatically merge PR once CI passes. label Jul 20, 2021
@ghost
Copy link

ghost commented Jul 20, 2021

Hello @epananth!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants