-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file-blob comparison #7997
Fix file-blob comparison #7997
Conversation
Can we do a test against any of the already existing builds? |
seems like it fixes some bug that repros when the exact file size is a multiple of 1 MB, but where is the bug this is fixing? |
While we assigned the existing build to different channel we saw some error -> https://dev.azure.com/dnceng/internal/_build/results?buildId=1404086&view=logs&j=ba23343f-f710-5af9-782d-5bd26b102304&t=6e277ba4-1c1e-552d-b96f-db0aeb4be20a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I've seen the failure being fixed I'm fairly convinced it'll fix it; please consider actually filing that bug for posterity's sake.
Created the issue -> #8004 |
I tested this against the failing build I had. |
This is a bug that always happens when this code path happens. The loop continues until the Read returns 0 indicating EOF, but the call to read 0 from the blob still happens and fails. |
To double check: