Fix Msi version string generation #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on operator precedence, `0x3FFF << 4` was happening first, ensuring that we always cut off the lower 4 bits of the build number when generating an Msi version. The good news appears to be that the Major and Minor stay the same or go up, though the patch value will go down. Before: A build number major value of 30327 or 30328 and build number value of 9 would generate `48.0.30329` After: `48.3.26489` and `48.3.26505`, respectively.
NikolaMilosavljevic
approved these changes
Aug 6, 2021
joeloff
approved these changes
Aug 6, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on operator precedence,
0x3FFF << 4was happening first, ensuring that we always cut off the lower 4 bits of the build number when generating an Msi version.The good news appears to be that the Major and Minor stay the same or go up, though the patch value will go down.
Before: A build number major value of 30327 or 30328 and build number value of 9 would generate
48.0.30329After:
48.3.26489and48.3.26505, respectively.To double check: