Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump template localizer version (unblocks adoption in dotnet/winforms) #8395

Merged
merged 1 commit into from
Feb 1, 2022

Conversation

ladipro
Copy link
Member

@ladipro ladipro commented Jan 26, 2022

Moving to latest version of the package in order to consume dotnet/templating#4267. This unblocks adoption of the template localizer in the winforms repo. See dotnet/winforms#6319 (comment) for context on the bug being fixed.

@ladipro
Copy link
Member Author

ladipro commented Jan 31, 2022

Mentioning @jonfortescue and @riarenas who reviewed the initial template localizer work. May I please get an approval for this change? Alternatively, I believe the component is ready to have a maestro subscription set up as suggested in #8233. I'll defer to your guidance. Thank you!

@riarenas
Copy link
Member

Approved so that winforms can get unblocked.

I believe the component is ready to have a maestro subscription set up as suggested in #8233. I'll defer to your guidance. Thank you!

Cool! in general with arcade, we leave the responsibility of managing the dependency flow subscription to the source repository as you are the ones in the best position to manage them.

Instructions on how to set up subscriptions for dependency flow consumption are available here: https://github.com/dotnet/arcade/blob/main/Documentation/DependencyFlowOnboarding.md#consuming. The doc has an example for how repos set up their arcade updates, but they are applicable to any package. Let @dotnet/dnceng if you need any further assistance with the instructions.

@ladipro ladipro merged commit 7c9ff50 into dotnet:main Feb 1, 2022
@ladipro ladipro deleted the bump-template-localizer branch February 4, 2022 10:29
ghost pushed a commit to dotnet/winforms that referenced this pull request Feb 4, 2022
PR reenables template localization disabled in #6441
Issue was fixed in dotnet/templating#4267 and available in latest version of arcade dotnet/arcade#8395.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants