Do not escape no-break space (\u00A0) #4267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlada-shubina
approved these changes
Jan 18, 2022
src/Microsoft.TemplateEngine.TemplateLocalizer.Core/LocalizableStrings.resx
Show resolved
Hide resolved
src/Microsoft.TemplateEngine.TemplateLocalizer.Core/TemplateStringUpdater.cs
Outdated
Show resolved
Hide resolved
test/Microsoft.TemplateEngine.TemplateLocalizer.Core.UnitTests/StringUpdaterTests.cs
Show resolved
Hide resolved
16 tasks
ladipro
added a commit
to dotnet/arcade
that referenced
this pull request
Feb 1, 2022
…tnet/winforms) (#8395) Moving to latest version of the package in order to consume dotnet/templating#4267. This unblocks adoption of the template localizer in the winforms repo. See dotnet/winforms#6319 (comment) for context on the bug being fixed.
ghost
pushed a commit
to dotnet/winforms
that referenced
this pull request
Feb 4, 2022
PR reenables template localization disabled in #6441 Issue was fixed in dotnet/templating#4267 and available in latest version of arcade dotnet/arcade#8395.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #4243
Solution
Creates a new javascript encoder to allow \u00A0 character to be not escaped.
Checks:
#nullable enableto all the modified files ? (nullability is enabled project-wide)