-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate template localizer into arcade #8233
Conversation
@jonfortescue Can you check to see if this looks OK? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fully support the change, having it available via arcade will simplify many template repos onboarding.
@@ -9,6 +9,10 @@ | |||
<Uri>https://dev.azure.com/dnceng/internal/_git/dotnet-symuploader</Uri> | |||
<Sha>62ceb439e80bf0814d0ffa17f022d4624ea4aa6c</Sha> | |||
</Dependency> | |||
<Dependency Name="Microsoft.TemplateEngine.Tasks" Version="7.0.100-alpha.1.21601.1"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this be updated automatically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially, no. But we should have some update method eventually, whether it is automatic or manual. For the time being, my current focus is to get this running smoothly on all dotnet repos which includes templates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that this package has entries in the BAR, so it should be simple to set up a maestro subscription so that this version gets updated automatically. We can set that up once this is merged and you're happy with how it's working.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riarenas, that sounds great! I will ping you if that's OK, once I confirm that everything is running fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great to me, as long as you've made sure it's tested and working!
cc/ @markwilkie for visibility
nice! |
To allow all repos under dotnet to easily localize templates, we are looking to integrate TemplateLocalizer task into arcade.
I'm not a 100% sure if this is the right way to implement this, so here is an early draft PR.
The intent is to allow turning template localizations on a repo, simply by setting "UsingToolTemplateLocalizer" property to true.
This is very much like how Xliff tools are setup (except for throwing errors on CI), so my changes here are very similar to what was done for Xliff tools.
To double check: