Remove LCID from UpgradeTable

[joeloff]

Description

Workload manifest installers currently configure the language column of the MSI upgrade table. When the MSI is included in a bundle and running under local SYSTEM, the bundle defaults to querying installed products against the user unmanaged context first. The INSTALLPROPERTY_LANGUAGE cannot be queried in this context (see https://docs.microsoft.com/en-us/windows/win32/api/msi/nf-msi-msigetproductinfoexw)

The logic in the setup engine reports the failure, but doesn't query the machine context and plans the MSI package for execution. When the planned MSI is a lower version than what's already installed, the engine fails to detect this. By allowing the MSI to execute, it then triggers the downgrade launch condition. The MSI terminates with 1603 as expected, but then the bundle rolls back and fails the overall install.

Fix

We don't need to set the language ID in the upgrade table and removing it will work around the error in Burn (bundle engine).

[joeloff]

@ericstj @NikolaMilosavljevic I decided to make the smallest change possible. Alternatively, I could have just used the MajorUpgrade element that's available to WiX, but that's a larger change.

[joeloff]

cc @jonathanpeppers @pjcollins since this will eventually impact workload manifest generation

[ericstj]

This looks reasonable to me. It removes the language constraint on the upgrade so it's unlikely to break anything, just make the upgrade apply more broadly. I can see how this fixes the issue described. Nice find.