Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update arcade dependency for Preview 11 release branch and rebuild / release 6.0.1xx workloads / packs #4319

Closed
Redth opened this issue Jan 25, 2022 · 8 comments
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions proposal/open

Comments

@Redth
Copy link
Member

Redth commented Jan 25, 2022

Update arcade dependency for Preview 11 release branch and rebuild / release 6.0.1xx workloads / packs.

@jonathanpeppers
Copy link
Member

I think we could put an empty commit on the preview 11 release branches, and the latest yaml-templates would get picked up?

https://github.com/xamarin/yaml-templates/commit/187da5eb2d64319573021ab424d6c2d9a585e2e3

@pjcollins does that sound right?

@pjcollins
Copy link
Member

pjcollins commented Jan 25, 2022

That sounds correct to me, assuming all the branches are referencing yaml-templates/main (which I believe they are). I don't have all of the context for this, is there a reason this is only needed for preview 11 and not other branches? Do we only need this fix dotnet/arcade#8330, or do we need something newer as well?

@jonathanpeppers
Copy link
Member

Preview 11 shipped alongside .NET 6 GA, so I think that is the reason they need this.

Preview 12 only shipped with a preview 6.0.200 SDK, so 6.0.200 will be fixed by the next Preview 13 release.

@rolfbjarne
Copy link
Member

So just to confirm: I put an empty commit here: https://github.com/xamarin/xamarin-macios/commits/release/6.0.1xx-preview11, and that's it?

@pjcollins
Copy link
Member

Yeah that should be all that is needed on the build side, though I'm not sure what distribution needs to happen after that. I assume we'll need to push the new packages to NuGet.org, but will we also need to put them into VS?

rolfbjarne added a commit to xamarin/xamarin-macios that referenced this issue Jan 26, 2022
@rolfbjarne
Copy link
Member

Done: xamarin/xamarin-macios@a000c8f

@Eilon Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jan 28, 2022
@jfversluis
Copy link
Member

This is a couple of previews old now, is this still needed?

@jonathanpeppers
Copy link
Member

I think the .NET SDK team basically just removed optional workloads from 6.0.102? to solve this problem. Since MAUI Preview 14 requires 6.0.200, that seemed like the easiest fix.

I think we can close this.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions proposal/open
Projects
None yet
Development

No branches or pull requests

10 participants