Remove empty XHarness logs #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattGal
approved these changes
May 20, 2021
akoeplinger
approved these changes
May 20, 2021
ChadNedzlek
reviewed
May 21, 2021
| @@ -156,6 +160,9 @@ fi | |||
| # The simulator logs comming from the sudo-spawned Simulator.app are not readable by the helix uploader | |||
| chmod 0644 "$output_directory"/*.log | |||
|
|
|||
| # Remove empty files | |||
| find "$output_directory" -name "*.log" -maxdepth 1 -size 0 -print -delete | |||
There was a problem hiding this comment.
I wonder if helix should just not upload zero-byte files in general. It seems sort of pointless to do.
There was a problem hiding this comment.
I was thinking the same but no idea if someone relies on it somehow somewhere
greenEkatherine
approved these changes
May 21, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we added few more log files which are sometimes empty (app's
.err.logfor example), let's not upload them to Helix