Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Helix Docker image for test reporting #7790

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented Aug 25, 2021

Couldn't reopen #7584 for some reason, so making a fresh PR.

Follow up from #7383. This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation

To double check:

… This means we now depend on the Helix clients to do reporting, and the code path is somewhat different for Docker, so let's test one docker variation
@MattGal MattGal requested a review from ChadNedzlek August 25, 2021 16:46
@MattGal MattGal changed the title Include Helix Docker image for test reporting : Include Helix Docker image for test reporting Aug 25, 2021
@MattGal MattGal added the auto-merge Automatically merge PR once CI passes. label Aug 25, 2021
@ghost
Copy link

ghost commented Aug 25, 2021

Hello @MattGal!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@MattGal
Copy link
Member Author

MattGal commented Aug 25, 2021

Skimmed logs of the runs, dockerized reporting looks good

@ghost
Copy link

ghost commented Aug 25, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Azure Pipelines
  5. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@ghost
Copy link

ghost commented Aug 25, 2021

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. Codecov
  3. DotNet Maestro
  4. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at [email protected] to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@MattGal MattGal merged commit cf9a9a6 into main Aug 25, 2021
@dougbu dougbu deleted the test-reporting-docker branch August 26, 2021 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants