Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update arcade-validation steps #7891

Merged
merged 4 commits into from
Nov 6, 2021
Merged

Update arcade-validation steps #7891

merged 4 commits into from
Nov 6, 2021

Conversation

epananth
Copy link
Member

To double check:

@epananth
Copy link
Member Author

epananth commented Nov 5, 2021

@riarenas @MattGal please take a look at this doc.

I updated this when I saw some discrepancies during branching.

MattGal
MattGal approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@MattGal MattGal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, I wonder if it'd be better to describe the location instead of locking in to a commit in the yaml that could get really old

Documentation/Policy/ArcadeServicing.md Outdated
- Get-AzDOHeaders (https://github.com/dotnet/arcade-validation/blob/71d3397e87e13ae2e9fd9d9af9725cfb53942c55/eng/validation/update-channel.ps1#L30)
- Get-LatestBuildResult (https://github.com/dotnet/arcade-validation/blob/71d3397e87e13ae2e9fd9d9af9725cfb53942c55/eng/validation/update-channel.ps1#L37)
- Remove the reference to bellweather repos (https://github.com/dotnet/arcade-validation/blob/main/eng/validation/update-channel.ps1#L54-#L76) and (https://github.com/dotnet/arcade-validation/blob/71d3397e87e13ae2e9fd9d9af9725cfb53942c55/eng/validation/update-channel.ps1#L85)
In azure-pipeline.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file name is azure-pipelines.yml

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated this

@epananth epananth added the auto-merge Automatically merge PR once CI passes. label Nov 5, 2021
@ghost
Copy link

ghost commented Nov 5, 2021

Hello @epananth!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@epananth epananth merged commit cfc0456 into dotnet:main Nov 6, 2021
@danmoseley danmoseley mentioned this pull request Feb 7, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@riarenas riarenas riarenas approved these changes

@MattGal MattGal MattGal approved these changes

@lukas-lansky lukas-lansky Awaiting requested review from lukas-lansky

Assignees
No one assigned
Labels
auto-merge Automatically merge PR once CI passes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epananth @MattGal @riarenas