Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocomplete PR flag for OneLocBuild template #7228

Merged

Conversation

jonfortescue
Copy link
Contributor

@jonfortescue jonfortescue commented Apr 12, 2021

Closes dotnet/core-eng#12766.

Defaults turning off PR autocompletion for OneLocBuild which is what we want for security reasons.

Test runs:

To double check:

Copy link
Member

@ChadNedzlek ChadNedzlek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the behavior of the tag is implemented elsewhere?

@jonfortescue
Copy link
Contributor Author

Yep! If anyone wants to turn on PR autocompletion, they need to set it to true in their build YAML. Otherwise it defaults to false (which is the right behavior since we don't want to grant the bot branch security override permissions).

@jonfortescue jonfortescue merged commit 69b0cf8 into dotnet:main Apr 14, 2021
@jonfortescue jonfortescue deleted the OneLocBuildPrAutocompletionFlag branch April 14, 2021 16:00
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
jonfortescue added a commit to jonfortescue/arcade that referenced this pull request Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants