Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for https://github.com/dotnet/arcade/issues/7371 #7421

Merged
merged 2 commits into from
May 21, 2021

Conversation

MattGal
Copy link
Member

@MattGal MattGal commented May 20, 2021

Have azure-pipelines reporter parse XML for failures if ADO fails for any reason, return 0 if we actually passed until the Helix Client does this itself.

To double check:

Since this is a weird error-case from an API we don't have a way to mock, I created this run where every worker in the Azure-DevOps reporter crashes. Note in that run the non-XUnit results were expected to and did fail because I didn't check for them; this is just to mitigate the main stream scenario of XUnit results. If we need to keep this workaround for a longer time can implement that.

Helix Log

Reporting has failed.  Running mitigation for https://github.com/dotnet/arcade/issues/7371
Searching 'C:\h\w\A8DD094C\w\B173094F\e' for test results files
Found results file C:\h\w\A8DD094C\w\B173094F\e\testResults.xml 
Searching 'C:\h\w\A8DD094C\w\B173094F\uploads' for test results files
Reporter script has failed, but we were able to find XUnit test results with no failures.

…or failures if ADO fails for any reason, return 0 if we actually passed.
@MattGal MattGal marked this pull request as ready for review May 20, 2021 22:28
Copy link
Member

@agocke agocke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants