Fix RuntimeInformation.FrameworkDescription in DiscovererHelpers #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons unknown, the first part of the IsRunningOnNetCoreApp check (Environment.Version.Major) was returning 0 for iOS & tvOS CI runs. The second part also failed because FrameworkDescription is no longer .NET Core. As a result, tests that should be skipped were no longer and causing unexpected failures on CI.
steveisok
requested review from
premun,
akoeplinger,
safern and
ViktorHofer
premun
approved these changes
Sep 27, 2021
|
Should we follow-up on why the major version returns 0? |
ViktorHofer
approved these changes
Sep 27, 2021
Yeah, that's my intent. Very strange. |
akoeplinger
reviewed
Sep 29, 2021
| @@ -14,7 +14,7 @@ internal static class DiscovererHelpers | |||
| { | |||
| private static readonly Lazy<bool> s_isMonoRuntime = new Lazy<bool>(() => Type.GetType("Mono.RuntimeStructs") != null); | |||
| public static bool IsMonoRuntime => s_isMonoRuntime.Value; | |||
| public static bool IsRunningOnNetCoreApp { get; } = (Environment.Version.Major >= 5 || RuntimeInformation.FrameworkDescription.StartsWith(".NET Core", StringComparison.OrdinalIgnoreCase)); | |||
| public static bool IsRunningOnNetCoreApp { get; } = (Environment.Version.Major >= 5 || RuntimeInformation.FrameworkDescription.StartsWith(".NET", StringComparison.OrdinalIgnoreCase)); | |||
There was a problem hiding this comment.
@steveisok this is wrong since it'll start returning true on .NET Framework since that also starts with .NET.
I'd do !RuntimeInformation.FrameworkDescription.StartsWith(".NET Framework", ... instead.
steveisok
pushed a commit
to steveisok/arcade
that referenced
this pull request
Sep 29, 2021
dotnet#7965 wasn't quite right as it would be true on full framework
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons unknown, the first part of the IsRunningOnNetCoreApp check (Environment.Version.Major) was returning 0 for iOS & tvOS CI runs. The second part also failed because FrameworkDescription is no longer .NET Core. As a result, tests that should be skipped were no longer and causing unexpected failures on CI.