0.13 log metadata #4232
Closed
0.13 log metadata #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a simple oversight in #3960
* fix(k8s): retry exec attempts in PodRunner Before this change, the Kubernetes API request sent as part of PodRunner exec calls have not been retried. This change makes sure that we use the existing Kubernetes API retry implementation and at the same time it makes sure that HttpErrors are wrapped properly, for improved error messages. * fix(k8s): wrap k8s errors for better error messages This change makes sure that we wrap exec k8s errors like we do for other Kubernetes API endpoints. This improves the error messages. * improvement: only retry if the error is recoverable Only retry on 500, 502, 503 and 429 errors to reduce the risk that the command is being executed twice. co-authored-by: tim <[email protected]> --------- Co-authored-by: tim <[email protected]>
Co-authored-by: Walther <[email protected]>
Co-authored-by: Walther <[email protected]>
* improvement: track the command run result and duration * chore: refactor analytics naming and types
0.13 fix: logger init in emit warning
…dback See the added/updated test cases for detail. cc @trymbill
In a handful of places the rendered output assumes the fancy logger is being used and it really doesn't play nice with the basic logger. This commit adds a logger "type" field to the root Logger and in a handful of places tweaks a given log message depending on the that type. This is a prerequisite to making the basic logger the default but we still need to add some sort of a status indicator at the bottom before doing that since otherwise it's hard to tell whether Garden is still executing or waiting for changes when in persistent mode.
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.4.0. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3.3.0...24cb908) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.6 to 2.2.7. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16964e9...168b99b) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.76.1. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.74.0...v5.76.1) --- updated-dependencies: - dependency-name: webpack dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
--------- Co-authored-by: Vladimir Vagaytsev <[email protected]>
Preparation for making templates support actions. This is backwards-compatible for users.
…te kind This adds support for templating actions and workflows in ConfigTemplate configs (formerly ModuleTemplate). The old way of referencing templates (a Module with `type: templated`) is also superseded by a new `kind: RenderTemplate` config, with largely the same semantics, except with an added `configs` field that supports actions and workflows. The resolution flow is very similar for actions and workflows, as it was (and remains for now) for modules. For now we have left out the option to generate files in the source tree, which is possible with the now-deprecated `generateFiles` field on modules. We may later consider making that a native feature on `RenderTemplate` configs as opposed to on the templated configs themselves, but it may be an unnecessary feature since that can in most cases be handled by `exec` actions.
improvement: deduplicate deploy status logs for ready statuses
Before this fix, the log line emitted in `BuildTask`'s `process` method was a rather confusing, since it seemed to indicate that the build was complete before it was executed.
Also, we now only run one daemon per Garden project at any time, with a single data directory. None of that temp directory business, symlinks and whatnot. Further, we get updates from Mutagen instantly via a single `mutagen sync monitor` process instead of execing a `mutagen sync list` process every 2 seconds. A side-effect of that is that our logging is maybe a touch noisy. I left a TODO to address that.
…ject dir Just happened upon this while working on other things nearby.
Previously, we'd only stream Garden events to websocket subscribers but not actual log entries. This meant clients could only respond to events and subscribe to service logs but not render actual Core log entries. This fixes that by simply piping log events to websocket subscribers.
Not sure how this got in there in the first place.
Now the daemon will be started if it's not running.
* refactor: rename `action` to `actions` in template context * docs: re-generated docs * chore(examples): update configs and readmes * test: update configs in test projects * test: update configs in unit tests * docs: update docs (all but reference guides) The references guides are generated automatically. * chore: update hard-coded template string literal * chore: remove todo-comment * style: formatting
Before this fix, adding a space at the end of a command invocation in the `dev` command would result in unexpected CLI argument parsing behavior (e.g. no Deploys being requested when running `deploy --logs` with a trailing space).
) * fix(commands): make test `-n` option backwards compatible to 0.12 Change the `-n` option to search for test actions matching the pattern `*-<name>`, to make the option backwards compatible to the behaviour in 0.12. Fixes #4178
remote actions didn't work as the tree version wasn't evaluated properly due to the action base path being wrong.
Co-authored-by: Orzelius <[email protected]>
* docs: update remote-sources guide * docs: typo
* don't unmount component on ctr-c * cancel timeouts * log final before unmount
I though switching to a kubernetes-exec type got rid of the issue but that doesn't seem to be the case. This should fix the flaky ci.
sometimes runs would fail if pod was manually killed in the past before even the run was started
When starting the CLI, a buffered event stream is created that subscribes to events from a Garden instance. However, when running a serve command, a new Garden instance is created via the "reload" function which the buffered event stream wasn't subscribing to. This commit fixes that by setting the new instance explicitly on the buffered event stream. This is pretty hacky and just a workaround to unblock things which will be removed when we introduce a proper instance manager.
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.3.2 to 2.3.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f3feb00...29b1f65) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@6b3083a...128a634) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
harden-runner would be useful in our actual build or release workflows, but has no benefits actually in lint and scorecard.
adds the required apiVersion field to created project file using garden create.
Co-authored-by: Tim Beyer <[email protected]> Co-authored-by: Eyþór Magnússon <[email protected]>
This fixes an issue where test logs are not streamed to Cloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original-coloroption fromgarden logscommandshow-containeroption fromgarden logscommandallow-dirtyoption fromgarden publishcommandsternfrom k8s plugin's toolsfaas-clifrom the list of macos dependenciescommandsunit tests (test: graph-v2 fixes forcommandsunit tests #3115)metaconfig fieldconfig-graph.tsvarfilesdefinition in the base action config schemagetActionTemplateReferencesactionConfigsschema definitionbaseRuntimeActionConfigschemabuildActionConfigtobuildActionConfigSchematestActionConfigtotestActionConfigSchemarunActionConfigtorunActionConfigSchemadeployActionConfigtodeployActionConfigSchemamodule actionstestsruninstead oftaskin artifact keyevent-handlers.tsrun service/deploycommandrun module/buildcommandrun workflowcommand torun-workflowrun testcommandrun taskcommand torungarden runand add watch modegarden callcommandgarden scancommandyarn.lock./container/build/buildkit.tsKubernetesDeployActionSpec./port-forward.ts./container/service.tsbuildspecdeployExecServicespecrunExecTaskspecgetExecServiceStatusspecdeleteExecServicespecget debug-infocommandget configtestsget statuscommand + updated testsget test-resultschema + testsget testsschema + testsyarn.lockExecCommandRunCommanddelete environment--with-dependants flag + testsget-run-result.tscompatibleTypesof a base action in the ctormakeTestModulehelperDEFAULT_API_VERSIONwhere possiblegarden devcommand implementationgetDataDirhelper where possiblegetDataDirhelper where possiblegetDataDirhelper ingarden.tsgetDataDirhelper functiongetAction(s)ByKindgetNameshelper where applicablecontainerservices./local-mode.tsexecprovider and its configconvertModulesfunctionconvertspec to own independent contextactionandruntimeDEFAULT_API_VERSIONexecmodule typemakeTempDirhelpermakeTempDirhelper where possibleexpectErrorto examine error messagesExecBuildSpec->ExecModuleBuildSpecExecModuleBuildSpecfrom extendingBaseBuildSpecBaseBuildSpecexpectErrorhelper in template string testscontainspredicate inexpectErrorexpectErrorhelperexpectErrorhelperexpectErrorhelperexpectErrorhelper in commands testsDockerfilein base-image exampleshell: trueoption to exec action specsgetResourceKeyhelper where possibleconfigureaction handlercontainerNamefrom k8s local mode specdemo-projectexampletimeoutfrom build action specasyncfrom function definitionhadolinttov.2.12.0garden devcommandterraform init#3632)syncFromSrchelperconfigureaction handlertypefieldcachedstate to eventsutil mutagencommand to ease troubleshooting sync issuessync startandsync stopcommandsself-updatecommand (improvement: more granular version control inself-updatecommand #3999)test-release.shset default-envcommandself-updatecommand (feat: support pre-release versions inself-updatecommand #4022)set default-env ''modulesproject config entry toscan(refactor: renamemodulesproject config entry toscan#4036)kubernetes-deployexampleexeccommand from running any deployments (0.13 fix exec to not deploy anything #4052)local.demo.gardenin the configs added in 0.130.13terms (docs: update local mode guide to use0.13terms #4106)-ialias for interactive mode inexeccommandgarden communitycommand (feat:garden communitycommand #4129)startSyncflag inDeployTaskParamsgetDependencyParams()apiVersion-field when using action kinds (feat: 0.13: MandatoryapiVersion-field when using action kinds #4102)run-workflowtoworkflow(refactor: renamerun-workflowtoworkflow#4187)runcommandactiontoactionsin template context (refactor: renameactiontoactionsin template context #4194)-noption backwards compatible to 0.12 (fix(commands): make test-noption backwards compatible to 0.12 #4208)What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: