Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update code-synchronization example to use actions #3822

Merged
merged 8 commits into from
Mar 8, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Feb 21, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3815

Special notes for your reviewer:

This also fixes the command override for sync mode in Kubernetes deployments. Without the code change, the Kubernetes deployment always started with the default args (npm start) instead of using the specified command (npm run dev).

@vvagaytsev vvagaytsev requested a review from thsig February 21, 2023 16:09
Copy link
Collaborator

@thsig thsig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Had a couple of suggestions there.

core/src/plugins/kubernetes/sync.ts Outdated Show resolved Hide resolved
examples/code-synchronization/node-service/garden.yml Outdated Show resolved Hide resolved
@Walther Walther requested a review from thsig March 1, 2023 10:47
@thsig thsig merged commit de3471f into 0.13 Mar 8, 2023
@thsig thsig deleted the 3815-code-synchronization branch March 8, 2023 11:48
This was referenced May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants