chore(ci): fix gcloud gke auth #4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edvald
approved these changes
May 3, 2023
|
Good catch! Adding to macos and windows setup sections too. EDIT: macos had already been added, added windows. |
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes CI runs for
helmcli invocations against a GKE cluster.We have already installed the newer
gkeauth plugin, and it works by default forkubectl. However, thehelmcli does not use it unless you specify the env var.helm/helm#11069
Special notes for your reviewer:
https://cloud.google.com/blog/products/containers-kubernetes/kubectl-auth-changes-in-gke