Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release workflow #3693

Merged
merged 2 commits into from
Feb 7, 2023
Merged

ci: fix release workflow #3693

merged 2 commits into from
Feb 7, 2023

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Feb 7, 2023

What this PR does / why we need it:

  • ci: remove deprecated homebrew workflow

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow reusable-create-homebrew-pr)

  • ci: fix release condition for homebrew pr creation

There was a small logical error in the release condition.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow `reusable-create-homebrew-pr`)
There was a small logical error in the release condition.
@stefreak stefreak merged commit 29305e2 into main Feb 7, 2023
@stefreak stefreak deleted the fix-release-workflow branch February 7, 2023 08:03
mkhq pushed a commit that referenced this pull request Feb 8, 2023
* ci: remove deprecated homebrew workflow

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow `reusable-create-homebrew-pr`)

* ci: fix release condition for homebrew pr creation

There was a small logical error in the release condition.
vvagaytsev pushed a commit that referenced this pull request Mar 6, 2023
* ci: remove deprecated homebrew workflow

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow `reusable-create-homebrew-pr`)

* ci: fix release condition for homebrew pr creation

There was a small logical error in the release condition.
vvagaytsev pushed a commit that referenced this pull request Mar 7, 2023
* ci: remove deprecated homebrew workflow

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow `reusable-create-homebrew-pr`)

* ci: fix release condition for homebrew pr creation

There was a small logical error in the release condition.
vvagaytsev pushed a commit that referenced this pull request Mar 7, 2023
* ci: remove deprecated homebrew workflow

Reason is that it does not work anyway, and it has been superseded by
publish-release (and the reusable workflow `reusable-create-homebrew-pr`)

* ci: fix release condition for homebrew pr creation

There was a small logical error in the release condition.
This was referenced May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants