Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(exec): more informative error msg on timeout #3584

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

stefreak
Copy link
Member

@stefreak stefreak commented Jan 25, 2023

What this PR does / why we need it:

  • Made the exec module error message on timeout more informative.
  • Updated the test

Still working on the kubernetes module, but decided to put this as a separate PR

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@stefreak stefreak requested review from eysi09 and 10ko January 25, 2023 11:38
@stefreak stefreak force-pushed the deploy-timeout-errors branch from b45036e to dd95154 Compare January 25, 2023 12:56
Copy link
Member

@10ko 10ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but I'd leave a comment. Would it make sense to add these error messages to a util file of some sort in order to reuse it in other plugins?
Or are we ok with duplicating the messages across them in order to maintain isolation?

@stefreak
Copy link
Member Author

Approving but I'd leave a comment. Would it make sense to add these error messages to a util file of some sort in order to reuse it in other plugins? Or are we ok with duplicating the messages across them in order to maintain isolation?

Good question, right now this error message exists in only one place (the kubernetes one will be different) – maybe we can extract it to a helper function once we have multiple plugins that throw this error (at least searching for "Timed out" in the code base only revealed exec and kubernetes plugins, and docker swarm but I think that's probably not a supported / tested one?)

@10ko
Copy link
Member

10ko commented Jan 25, 2023

Ok, gotcha, I was under the impression the error messages would be the same. This might be a conversation worth having at some point though, it would be nice to find a way to render similar error messages across different plugins. I would possibly require a bit of change in conventions/architecture and we can discuss it on a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants