refactor: renamed delete commands #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
rename-delete-commands
branch
from
6cec321 to
828c520
Compare
vvagaytsev
force-pushed
the
rename-delete-commands
branch
from
828c520 to
a1e39df
Compare
edvald
reviewed
Jul 20, 2022
| @@ -24,9 +24,8 @@ import { LogEntry } from "../logger/log-entry" | |||
| import { uniqByName } from "../util/util" | |||
|
|
|||
| export class DeleteCommand extends CommandGroup { | |||
| name = "delete" | |||
| alias = "del" | |||
There was a problem hiding this comment.
I'd suggest keeping delete as an alias.
edvald
reviewed
Jul 20, 2022
| alias = "env" | ||
| help = "Deletes a running environment." | ||
| name = "namespace" | ||
| alias = "ns" |
There was a problem hiding this comment.
Maybe throw a TODO-G2 comment in here. I had already made a plural aliases field in the graph-v2 branch, and it'd be good to have environment and env in there as aliases as well.
vvagaytsev
changed the title
Orzelius
approved these changes
Jul 21, 2022
|
@Orzelius thank you! Yes, we'll rename the files later. |
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR only contains the user-facing parts for now. We can rename internals later. The internal includes the classes like
DeleteXxx[Command|Params|Result], some handlers, methods and functions in the action router, local variables, etc.Changing the internal now can cause extra conflicts with https://github.com/garden-io/garden/tree/graph-v2.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: