fix: re-initialize providers changing environments #3481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefreak
force-pushed
the
fix-resolve-provider
branch
from
28529eb to
69afab8
Compare
When users change environments, we need to re-initialize providers.
Let's consider the following example:
User has a provider config like so:
```
providers:
- name: exec
initScript: echo ${environment.name} > someFile
```
If user runs a garden command with --env foo, and then with --env bar,
and then again with --env foo we would expect `someFile` to contain `foo`. But
the file actually contains bar.
Reason for this is that garden skipped executing the initScript in the foo env,
because it has already been executed. But the cache logic is not aware that the
last command that ran was in the bar env.
This commit fixes that problem.
co-authored-by: srihas-g <[email protected]>
stefreak
force-pushed
the
fix-resolve-provider
branch
from
69afab8 to
dbf2df4
Compare
Reasoning is that when the env name changes and that is relevant, the provider config changes too (assuming that we do not implicitly pass additional information like the environment name using env variables)
stefreak
force-pushed
the
fix-resolve-provider
branch
from
654fbd0 to
bc1372c
Compare
co-authored-by: Walther <[email protected]>
stefreak
force-pushed
the
fix-resolve-provider
branch
from
bc1372c to
d0032f0
Compare
Walther
reviewed
Jan 3, 2023
stefreak
force-pushed
the
fix-resolve-provider
branch
from
005af72 to
f8cbe7a
Compare
|
I wonder if the new test will just run on circleci, or if I have to change the circleci yaml to include the new |
Orzelius
approved these changes
Jan 3, 2023
|
The integ test should just run, along with the rest of the integ test suite. You should be able to confirm by looking at the vm test logs. |
edvald
approved these changes
Jan 3, 2023
stefreak
added a commit
that referenced
this pull request
Jan 4, 2023
* fix: re-initialize providers changing environments
When users change environments, we need to re-initialize providers.
Let's consider the following example:
User has a provider config like so:
```
providers:
- name: exec
initScript: echo ${environment.name} > someFile
```
If user runs a garden command with --env foo, and then with --env bar,
and then again with --env foo we would expect `someFile` to contain `foo`. But
the file actually contains bar.
Reason for this is that garden skipped executing the initScript in the foo env,
because it has already been executed. But the cache logic is not aware that the
last command that ran was in the bar env.
This commit fixes that problem.
* improvement: remove unnecessary check for env name
Reasoning is that when the env name changes and that is relevant,
the provider config changes too (assuming that we do not implicitly
pass additional information like the environment name using env
variables)
* tests: add an integration test
Co-authored-by: srihas-g <[email protected]>
Co-authored-by: Walther <[email protected]>
edvald
pushed a commit
that referenced
this pull request
Jan 7, 2023
* fix: re-initialize providers changing environments
When users change environments, we need to re-initialize providers.
Let's consider the following example:
User has a provider config like so:
```
providers:
- name: exec
initScript: echo ${environment.name} > someFile
```
If user runs a garden command with --env foo, and then with --env bar,
and then again with --env foo we would expect `someFile` to contain `foo`. But
the file actually contains bar.
Reason for this is that garden skipped executing the initScript in the foo env,
because it has already been executed. But the cache logic is not aware that the
last command that ran was in the bar env.
This commit fixes that problem.
* improvement: remove unnecessary check for env name
Reasoning is that when the env name changes and that is relevant,
the provider config changes too (assuming that we do not implicitly
pass additional information like the environment name using env
variables)
* tests: add an integration test
Co-authored-by: srihas-g <[email protected]>
Co-authored-by: Walther <[email protected]>
This was referenced Jan 26, 2023
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users change environments, we need to re-initialize providers.
Let's consider the following example:
User has a provider config like so:
If user runs a garden command with --env foo, and then with --env bar,
and then again with --env foo we would expect
someFileto containfoo. Butthe file actually contains bar.
Reason for this is that garden skipped executing the initScript in the foo env,
because it has already been executed. But the cache logic is not aware that the
last command that ran was in the bar env.
This commit fixes that problem.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: