refactor: rename action to actions in template context
#4194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
0.13-template-context-rename-action-to-actions
branch
from
dd22144 to
35e2ed6
Compare
The references guides are generated automatically.
vvagaytsev
force-pushed
the
0.13-template-context-rename-action-to-actions
branch
from
35e2ed6 to
ba9876a
Compare
|
This is ready for review now. All tests are green! |
vvagaytsev
changed the title
action to actions in template context
Walther
reviewed
May 9, 2023
| const { action, garden, partialRuntimeResolution, variables, inputs, resolvedDependencies, executedDependencies } = | ||
| params | ||
| const { | ||
| action, |
There was a problem hiding this comment.
just double checking: we're intentionally passing in a singular action here to the constructor?
There was a problem hiding this comment.
I think so. The assignment looks like this:
this.actions = new ActionReferencesContext(this, partialRuntimeResolution, [
...resolvedDependencies,
...executedDependencies,
])
The action is not used directly there. And the original TODO comment was about changing the template context syntax for better clarity.
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
See individual commits for details.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
The
action-types.hbstemplatehas already had
actionskey in the template strings.