chore: upgrade to node 18 #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walther
commented
Jan 30, 2023
Walther
commented
Jan 30, 2023
Comment on lines
+54
to
+55
| "start": "react-scripts --openssl-legacy-provider start", | ||
| "build": "react-scripts --openssl-legacy-provider build", |
There was a problem hiding this comment.
refuses to start otherwise on node 18. arguably mildly unsafe, but 1) this dashboard is for local dev, not running in production-like envs with public access 2) this dashboard is being removed anyway
Walther
force-pushed
the
node18-upgrade
branch
4 times, most recently
from
0b01d5d to
c1073c3
Compare
Walther
force-pushed
the
node18-upgrade
branch
from
c1073c3 to
70d6aa4
Compare
stefreak
approved these changes
Jan 30, 2023
Walther
added a commit
that referenced
this pull request
Jan 30, 2023
edvald
pushed a commit
that referenced
this pull request
Jan 30, 2023
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade to Node 18
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: