chore(examples): update remote-k8s example to use actions #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3846
Special notes for your reviewer:
I have now tested this enough with a GKE cluster to be personally comfortable with merging this.
Deploying and remote builds work, and the services are accessible via a custom hostname - with some not-committed, local changes required to the configuration, as per instructions.
I have also removed the mention of TLS configuration in the example, to keep this focused on the remote builds and deployments. We have other examples for
cert-manageruse, and using a load balancer for TLS termination is another viable choice for production workloads - either of which should be better than manually setting kube secrets.Squashing before merging.