fix: 0.13 export the status state-field consistently across action types #4073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks fine in principle, if you really need to revert the change that is. Maybe give me a ping once the tests are green, I can review again then. |
vvagaytsev
force-pushed
the
0.13-event-export-api
branch
from
d9e35db to
b287bd4
Compare
vvagaytsev
approved these changes
Apr 20, 2023
|
I fixed the schema definition and the tests, merging this now. |
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This ensures that the detailed status state-field is named consistently across action kinds. It reverts a previous commit which changed
state->deployStatefor thedeployaction.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Details in this thread: https://discord.com/channels/817392104711651328/1095652284379168869