feat: garden community command
#4129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orzelius
approved these changes
Apr 27, 2023
vvagaytsev
reviewed
Apr 27, 2023
| async action(): Promise<CommandResult> { | ||
| const discordInvite = "https://discord.gg/FrmhuUjFs6" | ||
| // eslint-disable-next-line no-console | ||
| console.log(discordInvite) |
There was a problem hiding this comment.
A colored message might be a better option here. Something like "Welcome to our community! Join us on Discord: {link}".
There was a problem hiding this comment.
My initial thought was to keep it simple and only output the link in order to make it easier to copy/paste for folks who are not using a terminal emulator that supports clickable link detection. The command is also calling an open handler, so the printed line is more of a backup method anyway, and leaves a trail of history for what was opened.
But I have no strong opinions here - we can also tweak this further if we want to, easy changes to make ❤️
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new command
garden communitythat opens the Garden Community Discord invite link.Which issue(s) this PR fixes:
Completes the task defined on the Q2 ideas Miro board.
Special notes for your reviewer:
Sorted the imports in
commands.tsas a separate commit, as they were almost sorted already.