Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update rust example to use action configs #3756

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented Feb 14, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #3740

Special notes for your reviewer:

First time converting an example to the new config format.
Is this correct and aligned with the best practices?

examples/rust/README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@vvagaytsev vvagaytsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great job! 👍
If the example works fine with and without --dev flag, then it's ready to go! 🚀

@Walther Walther merged commit ad99cb7 into 0.13 Feb 14, 2023
@Walther Walther deleted the 3740-example-rust branch February 14, 2023 12:10
@Walther
Copy link
Contributor Author

Walther commented Feb 14, 2023

Thanks for the speedy review!

This was referenced May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants