docs(k8s): update terraform-gke example for Bonsai #4000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to "one-shot" deploy the example a GKE cluster and our demo services, we need a kubeconfig. Because of #3475, a kubeconfig managed by Garden should be generated with elevated privileges.
To improve comprehension and expose the values a user should set for a project at the top of the file, we set the hardcoded values of the Garden project file to variables.
The README previously assumed a cluster ready to work with. We change the instructions to assume no pre-existing cluster.
Previously the GKE example was an all-in-one terraform file. I've chosen to make use of battle-tested GKE modules and split the terraform for easy comprehension.
Walther
reviewed
Mar 27, 2023
There was a problem hiding this comment.
Great work! 🚀
The example looks solid, and I like how you've simplified the readme and config.
I'll let an SRE double-check the terraform, as it has been a moment since I've written any.
And congratulations on getting the milestone of PR/Issue number 4000! That's a lot of work done to this repo 🎉
vvagaytsev
approved these changes
Apr 11, 2023
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR revs the
terraform-gkeexample to align with Bonsai's conventions. I've also taken the opportunity to atomize and update the Terraform to align with the battle-tested and Google-supported https://github.com/terraform-google-modules/terraform-google-kubernetes-engine project. See commit message bodies for more background on decisions taken.I've tested this module and have it running in the community-engineering project on Google Cloud.