fix(kubernetes): make preStop command work with busybox #3568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pgrep -c option does not exist in busybox. Make the preStop command more portable.
Walther
previously approved these changes
Jan 24, 2023
stefreak
commented
Jan 24, 2023
vvagaytsev
pushed a commit
that referenced
this pull request
Mar 3, 2023
* fix(kubernetes): make preStop command work with busybox The pgrep -c option does not exist in busybox. Make the preStop command more portable. This avoids a weird error message in the logs of Garden Pods including the util container.
vvagaytsev
pushed a commit
that referenced
this pull request
Mar 6, 2023
* fix(kubernetes): make preStop command work with busybox The pgrep -c option does not exist in busybox. Make the preStop command more portable. This avoids a weird error message in the logs of Garden Pods including the util container.
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The pgrep -c option does not exist in busybox. Make the preStop command more portable.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: