fix(core): override Build version with module #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For `BuildAction`s generated by converting modules, we now override
the `versionString` of the full version of `Build` actions with the
`versionString` of their parent module.
This fixes an issue where e.g. `helm` modules that referred to
`${modules.some-container-module.version}` would fail to deploy, since
the version of the Build action that `container-module` would get
converted to wouldn't match that of the `container` module that it was
converted from—this resulted in a different version being built than the
Helm chart expected, leading to image pull errors.
The same pattern is also standard when using `kubernetes` and
`container` modules in conjunction.
This should ease the transition from 0.12 to 0.13 for many projects.
thsig
force-pushed
the
override-build-version-with-parent-module
branch
from
a5c801b to
565ce12
Compare
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
For
BuildActions generated by converting modules, we now override theversionStringof the full version ofBuildactions with theversionStringof their parent module.This fixes an issue where e.g.
helmmodules that referred to${modules.some-container-module.version}would fail to deploy, since the version of theBuildaction thatcontainer-modulewould get converted to wouldn't match that of thecontainermodule that it was converted from—this resulted in a different version being built than the Helm chart expected, leading to image pull errors.The same pattern is also standard when using
kubernetesandcontainermodules in conjunction.This should ease the transition from 0.12 to 0.13 for many projects.