Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add backwards compatibility for old-style run commands #4195

Merged
merged 4 commits into from
May 8, 2023

Conversation

Walther
Copy link
Contributor

@Walther Walther commented May 8, 2023

What this PR does / why we need it:

Adds backwards compatibility for old-style run command invocations.

cd examples/vote/;
garden run task db-init;
garden run workflow full-test;

Which issue(s) this PR fixes:

Fixes #4166

Special notes for your reviewer:

I would appreciate if the reviewers could try this out on some known-working workflows and tasks to verify the backwards compatibility works, by using the old-style garden run workflow foo, garden run task foo, garden run test foo invocations. These should be run against both 0.12 style and 0.13 style config files.

Pardon the slightly hacky implementation. If you have suggestions on how to make this cleaner, I'm all ears <3

core/src/commands/run.ts Outdated Show resolved Hide resolved
stefreak
stefreak previously approved these changes May 8, 2023
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, good work 👍
I like that you created tests for this.

Co-authored-by: Steffen Neubauer <[email protected]>
Copy link
Member

@stefreak stefreak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@Walther Walther merged commit 8f5218d into 0.13 May 8, 2023
@Walther Walther deleted the 0.13-old-style-run-commands branch May 8, 2023 16:35
@Walther
Copy link
Contributor Author

Walther commented May 8, 2023

I like that you created tests for this

I mostly copied over existing tests and converted the expectations from errors to warnings.
I left a TODO item for 0.14 - we should revert 2c8849a in order to make the warnings back into errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants