-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add backwards compatibility for old-style run commands #4195
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, good work 👍
I like that you created tests for this.
core/test/data/test-projects/old-style-run-invocations/garden.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Steffen Neubauer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I mostly copied over existing tests and converted the expectations from errors to warnings. |
What this PR does / why we need it:
Adds backwards compatibility for old-style
run
command invocations.Which issue(s) this PR fixes:
Fixes #4166
Special notes for your reviewer:
I would appreciate if the reviewers could try this out on some known-working workflows and tasks to verify the backwards compatibility works, by using the old-style
garden run workflow foo
,garden run task foo
,garden run test foo
invocations. These should be run against both0.12
style and0.13
style config files.Pardon the slightly hacky implementation. If you have suggestions on how to make this cleaner, I'm all ears <3