test: fix assertions for run command
#4204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garden emits non-repeatable warning "Project is configured with `apiVersion: garden.io/v0`, running with backwards compatibility." Thus, the variable `logMessages` may contain 2 lines. This commit introduces helper function `expectLogsContain` to check if there is at least one entry of a given sample among all log lines.
Merged
Walther
approved these changes
May 9, 2023
There was a problem hiding this comment.
I'm terribly sorry, this was my bad. I added the change for apiVersion in the config files at the last minute in the GitHub UI from a review suggestion, but did not wait for all the tests to complete before merging, as the tests had already passed before. I promise to be more careful in the future. Thank you for the quick fix! 🙇♂️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Garden emits non-repeatable warning "Project is configured with
apiVersion: garden.io/v0, running with backwards compatibility." Thus, the variablelogMessagesmay contain 2 lines. This commit introduces helper functionexpectLogsContainto check if there is at least one entry of a given sample among all log lines.What this PR does / why we need it:
Patch for #4195
Which issue(s) this PR fixes:
It makes the log-checking unit test assertions more stable by taking into account non-repeatable warnings.
Special notes for your reviewer: