refactor: rename modules project config entry to scan
#4036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvagaytsev
force-pushed
the
0.13-rename-modules-to-scan
branch
from
b6941a7 to
1f94a78
Compare
vvagaytsev
force-pushed
the
0.13-rename-modules-to-scan
branch
2 times, most recently
from
7e2c88a to
6c3835b
Compare
edvald
reviewed
Apr 3, 2023
core/src/config/project.ts
Outdated
| /** | ||
| * Deprecated. Use {@link #scan} instead. | ||
| * @deprecated remove in 0.14 | ||
| */ | ||
| modules?: { |
There was a problem hiding this comment.
I think we should just remove this from the internal interface.
There was a problem hiding this comment.
Removed it in 905f8ac
vvagaytsev
force-pushed
the
0.13-rename-modules-to-scan
branch
from
6c3835b to
905f8ac
Compare
edvald
reviewed
Apr 4, 2023
core/src/config/base.ts
Outdated
| } | ||
|
|
||
| if (projectSpec["modules"].include) { | ||
| const oldSyntaxInclusions = projectSpec["modules"].include || [] |
There was a problem hiding this comment.
Why not simply use the rename option in the joi schema? You can catch and emit the usage of the old field before validating.
There was a problem hiding this comment.
That was my initial plan. Should we deny using both fields simultaneously?
There was a problem hiding this comment.
Simplified this in 2966c7f
Use field renaming on the joi schema level.
edvald
approved these changes
Apr 4, 2023
This was referenced May 11, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3512
Special notes for your reviewer: