-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add migration guide from 0.12 to bonsai #4007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍
Very good initial version! Let's apply further improvements on top of it.
I've let a couple of comments, feel free to address/discuss :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the following is worth mentioning:
- Where is the reference documentation for actions
- Modules can't depend on actions
- Modules can't reference actions
- Actions can reference and depend on modules, by referencing the actions that are generated from modules
- Converting your project to the actions config can be performed gradually by starting from the end of the dependency tree
I think adding this resolution flow might make it more understandable:
- modules are resolved
- modules are converted to actions
- actions are resolved
Should we also include #3512 in the breaking changes list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, thanks! 🚀
This adds a rudimentary migration guide from 0.12 to Bonsai.
This is a bit of a minimum viable tutorial for pre-release purposes only. We should replace this with better documentation and a blog post later on.
Squash before merging to clean up the history.