v1.3.0 #205
Merged
v1.3.0 #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some implementations of select boxes require a placeholder to be designated for that select box. With our current version of the GoSelect component, we are not capable of adding a placeholder value. The NgSelect module allows us to pass it a placeholder for the select box. This adds the placeholder option as a binding to the GoSelect component and then leverages that binding when creating an NgSelect instance. I leverged the HTML for Template/Header/Footer[0] example that NgSelect provides in order to best implement this solution. [0] - https://github.com/ng-select/ng-select/blob/master/src/demo/app/examples/template-header-footer-example/template-header-footer-example.component.html
Add go-select documentation
Add Placeholder Binding to GoSelect Component
Seeing that are looking to add the Placeholder to the GoSelect box in v1.3.0, we should also release with up to date documentation on the GoSelect box that includes implementing the placeholder. This adds the placeholder documentation to the GoSelect page.
Add Placeholder to GoSelect Documentation
[Chore] Update Contribution and PR Template
Currently we have the ability to either have every column on a table sortable or none of them. There are certain cases where we want to be able to just sort by a couple columns on a table. This provides a way for an implementor to decide which columns can be sortable on a table or which columns they want to not be sortable.
Ability to Brand Side Nav and Accordion
[Chore] Action Sheet Documentation
Control state of per page dropdown from table config
Adds the ability to use a typeahead with go-select. This allows for things like fetching the results server side from a user searching for results.
Go File Upload
[Chore] Layout Adjustments
…f_canvas FEATURE: Add Icon and Header to Off Canvas
Go Select Async Items
StevenUlmer
approved these changes
Oct 31, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.3.0The
buttonVariantforpositivehas been removedIf there are
go-button's using thepositivevariant, temporarily those will be converted toprimary.In the future, this variant will be removed altogether.
The reasons for this are:
Changes Required
positiveRelevant PRs:
🚢 New Features
Buttons
Buttons have been overhauled with a new design. #271
Configuration Service
A new Angular service that can be used for various configurations in Goponents. The initial purpose of this service is for updating branding within the application.
Relavant PRs:
Layout
File Upload
A new form component for uploading files as been created. Allows for drag/drop and multiple files. #149
Select
Switch Toggle
Table
Off Canvas
🐞 Bug Fixes
Buttons
go-button-groupclass was not working properly because of encapsulation. Fix button group helper class not working #264Loader on Layout
z-indexwhich resulted in element below the loader showing through Chore z index for load screen #270Datepicker
Select
Table
perPageis set to something other than the first index inpageSizes, the Page Sizeselectwould still have the first option selected, even though the table has the configured page count. [BUG] Table per page dropdown always defaults to first option even when set #292, Control state of per page dropdown from table config #293✏️ General & Design
General
devbranch workflow [Chore] Update Contribution and PR Template #254Design
📄 Documentation
Added new documentation for:
Removed documentation for: