Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Placeholder to GoSelect Documentation #252

Merged
merged 1 commit into from
Oct 7, 2019

Conversation

mwagz
Copy link
Contributor

@mwagz mwagz commented Oct 7, 2019

Why do we need this?

Seeing that are looking to add the Placeholder to the GoSelect box in v1.3.0, we should also release with up to date documentation on the GoSelect box that includes implementing the placeholder.

How does this solve that problem?

This adds the placeholder documentation to the GoSelect page.

Seeing that are looking to add the Placeholder to the GoSelect box in
v1.3.0, we should also release with up to date documentation on the
GoSelect box that includes implementing the placeholder.

This adds the placeholder documentation to the GoSelect page.
@mwagz mwagz requested a review from grahamhency October 7, 2019 17:04
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@grahamhency grahamhency added this to the v1.3.0 milestone Oct 7, 2019
@grahamhency grahamhency merged commit ac2f534 into v1.3.0 Oct 7, 2019
@grahamhency grahamhency deleted the update_goselect_docs branch October 7, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants