Go-Footer #209
Merged
Go-Footer #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamhency
suggested changes
Oct 2, 2019
There was a problem hiding this comment.
Not exactly sure what's going on, but start up go-tester and look at http://localhost:4200/test-page-2
It's all messed up.
|
@StevenUlmer after you fix the issue I mentioned before, we'll need to add documentation for this. |
Merged
It uses content project to allow the implementer to decide what they want to put inside. The only thing we are doing is centering the content
StevenUlmer
force-pushed
the
go_footer
branch
from
89c856a to
21006eb
Compare
grahamhency
approved these changes
Oct 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #164
This creates a footer to be used within the layout. The footer isn't sticky and will appear at the end of the main content body after a user scrolls to the end. It uses content projection so the implementer can decide what they want to display inside of the footer. The only thing we're doing is centering the content that the user puts inside.