Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Checkbox Documentation #283

Merged
merged 1 commit into from
Oct 22, 2019
Merged

[Chore] Checkbox Documentation #283

merged 1 commit into from
Oct 22, 2019

Conversation

grahamhency
Copy link
Contributor

Problem

We did not have documentation covering the go-checkbox or the go-checkbox-group components.

Solution

Added documentation for both components.

Closes #228, #227

@grahamhency grahamhency added the documentation Style Guide needs updated label Oct 22, 2019
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 22, 2019
@grahamhency grahamhency changed the base branch from master to v1.3.0 October 22, 2019 14:03
@grahamhency grahamhency force-pushed the chore_checkbox_documentation branch from 5e92401 to 393cb6c Compare October 22, 2019 14:13
@grahamhency grahamhency force-pushed the chore_checkbox_documentation branch from 393cb6c to a68d29f Compare October 22, 2019 14:17
StevenUlmer
StevenUlmer approved these changes Oct 22, 2019
View reviewed changes
Copy link
Contributor

@StevenUlmer StevenUlmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Just the one question

...cts/go-style-guide/src/app/features/ui-kit/components/button-docs/button-docs.component.html Show resolved Hide resolved
@grahamhency grahamhency merged commit 8ae3299 into v1.3.0 Oct 22, 2019
@grahamhency grahamhency deleted the chore_checkbox_documentation branch October 22, 2019 20:41
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenUlmer StevenUlmer StevenUlmer approved these changes

Assignees
No one assigned
Labels
documentation Style Guide needs updated
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grahamhency @StevenUlmer