Fix button group helper class not working #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamhency
approved these changes
Oct 11, 2019
| @@ -181,14 +181,14 @@ $button__background--loading: rgba($theme-light-border, .4); | |||
| } | |||
| } | |||
|
|
|||
| .go-button-group { | |||
| ::ng-deep .go-button-group { | |||
There was a problem hiding this comment.
@patryk0605 I don't love that we're using ng-deep here, but I suppose it makes sense to keep these classes with the buttons.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #171
Button group helper classes were not working due to view encapsulation.
What is the new behavior?
Button helper classes are now exposed again for use.
Does this PR introduce a breaking change?
Other information
Closes: #171