Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Button Group helper classes not working #171

Closed
eligolding opened this issue Sep 10, 2019 · 1 comment
Closed

[BUG] Button Group helper classes not working #171

eligolding opened this issue Sep 10, 2019 · 1 comment
Assignees
@eligolding @patrick-lewandowski
Labels
bug Something isn't working in progress Work on this issue is in progress
Milestone
v1.3.0

Comments

@eligolding
Copy link
Contributor

eligolding commented Sep 10, 2019 •
edited
Loading

Description

Using the button group modifier classes has no effect, due to the encapsulation mode of the button component. This is a regression introduced by yours truly here. Previously these styles were all global.

Steps to reproduce the behavior:

  1. Try to use the go-button-group and go-button-group__item classes.
  2. Open the page in your browser de jour.
  3. See how the styles are not being applied.
  4. Be sad 😿

Expected behavior

Styles should be applied (duh)

Possible Resolutions

  1. Remove encapsulation from the button component (please no)
  2. Move there styles to a global file (maybe)
  3. Creat a component from button groups (good idea, more work that may not be high priority right now)
@eligolding eligolding added bug Something isn't working new issue This issue has yet to receive attention labels Sep 10, 2019
@grahamhency grahamhency added this to the Needs Triaged milestone Sep 13, 2019
@grahamhency grahamhency modified the milestones: Needs Triaged, v1.3.0 Oct 4, 2019
@patrick-lewandowski patrick-lewandowski mentioned this issue Oct 9, 2019
Merged
13 tasks
@patrick-lewandowski
Copy link
Contributor

@grahamhency possible fix: #264

@grahamhency grahamhency removed the new issue This issue has yet to receive attention label Oct 11, 2019
@grahamhency grahamhency added the in progress Work on this issue is in progress label Oct 14, 2019
grahamhency pushed a commit that referenced this issue Oct 14, 2019
@patrick-lewandowski @grahamhency
Fix button group helper class not working per issue #171
a4c53ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eligolding eligolding

@patrick-lewandowski patrick-lewandowski

Labels
bug Something isn't working in progress Work on this issue is in progress
Projects
None yet
Milestone
v1.3.0
Development

No branches or pull requests
3 participants
@eligolding @patrick-lewandowski @grahamhency