Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Add Icon and Header to Off Canvas #265

Merged
merged 4 commits into from
Oct 31, 2019
Merged

FEATURE: Add Icon and Header to Off Canvas #265

merged 4 commits into from
Oct 31, 2019

Conversation

deotte
Copy link
Contributor

@deotte deotte commented Oct 9, 2019

Issue

#240

Problem

Currently, the offCanvasComponent does not support the ability to add a custom header to the top. The only way you can render the offCanvasComponent is with the default header having a large close button at the top.

Solution

Added another binding to the goOffCanvasService.openOffCanvas call to be able to pass in a header. Because of the interesting way that the goOffCanvasComponent is rendered from the goOffCanvasService, I could not directly add an input to the component itself.

Before

Screen Shot 2019-10-09 at 3 09 14 PM

After

Screen Shot 2019-10-24 at 3 45 25 PM

@grahamhency grahamhency self-requested a review October 11, 2019 16:46
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 11, 2019
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deotte thanks for taking the initiative on this one. I've got a few changes and comments. The only thing missing here is updated documentation in the go-style-guide project. (See off-canvas-docs.component.html)

You can start the style guide project with npm run style_guide

@deotte deotte requested a review from grahamhency October 24, 2019 19:42
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@deotte this looks good to me! Thanks for making those changes.

@grahamhency grahamhency merged commit d366679 into mobi:v1.3.0 Oct 31, 2019
@grahamhency grahamhency mentioned this pull request Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants