-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: Add Icon and Header to Off Canvas #265
FEATURE: Add Icon and Header to Off Canvas #265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deotte thanks for taking the initiative on this one. I've got a few changes and comments. The only thing missing here is updated documentation in the go-style-guide
project. (See off-canvas-docs.component.html
)
You can start the style guide project with
npm run style_guide
projects/go-tester/src/app/components/off-canvas-test/off-canvas-test.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.module.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.ts
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.scss
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.scss
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.html
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.html
Outdated
Show resolved
Hide resolved
projects/go-lib/src/lib/components/go-off-canvas/go-off-canvas.component.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deotte this looks good to me! Thanks for making those changes.
Issue
#240
Problem
Currently, the
offCanvasComponent
does not support the ability to add a custom header to the top. The only way you can render theoffCanvasComponent
is with the default header having a large close button at the top.Solution
Added another binding to the
goOffCanvasService.openOffCanvas
call to be able to pass in aheader
. Because of the interesting way that thegoOffCanvasComponent
is rendered from thegoOffCanvasService
, I could not directly add an input to the component itself.Before
After