Add ability to brand top left header #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
October 18, 2019 12:52
jaredami
changed the title
grahamhency
suggested changes
Oct 21, 2019
There was a problem hiding this comment.
Overall looks pretty good.
Should we get some tests around this stuff?
Got an issue with the icons in the buttons, https://deploy-preview-281--romantic-khorana-d856b1.netlify.com/ui-kit/button.
|
@grahamhency I added tests for the GoConfigService and fixed the issue with the buttons you mentioned. |
grahamhency
suggested changes
Oct 22, 2019
There was a problem hiding this comment.
Hey @jaredami, I think we can simplify this icon issue further. Check my other comment.
| @@ -32,21 +32,21 @@ $icon-sizes: (small: 1rem, medium: 1.5rem, large: 2rem); | |||
| } | |||
|
|
|||
| .go-icon--dark { | |||
| color: $theme-dark-color; | |||
| color: $theme-light-color; | |||
There was a problem hiding this comment.
@jaredami I think instead of changing this. We can just remove the [iconModifier] being passed to the go-icon by the go-button. See line 18 in go-button.component.html. The inheritance should take over here.
Merged
grahamhency
approved these changes
Oct 23, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #245
This PR adds the ability to apply a branded background to the top left section of the header.
Our
GoConfigServicealready provides the ability to set a branding color. This PR adds the ability to toggle on and off whether this branding is applied to the header via the service'stoggleHeaderBrandingEnabledmethod.The header will use the service to ensure that the contrast ratio between the branded background and the color of the menu icon remain accessible by utilizing its
contrastIsAccessiblemethod.