Go File Upload

[devchris]

This attempts to close #127

[grahamhency]

@StevenUlmer we've already discussed this a bit, but can you look into what it would take for us to make the file upload process something like that InVision mockup?

[grahamhency]

Could we swap the "File Name" to a <label> here?

Also, let's add some padding to the right of the file name to separate the icon-button from the file name.

Also, let's make the border solid on the drag/drop section.

[StevenUlmer]

@grahamhency I think this is ready for another look

[grahamhency]

Got a few items to attend to, let me know if you have questions. This could also do with a rebase.

[grahamhency]

@StevenUlmer what if we extracted this out into it's own thing? We could pass in the go-file-upload--active class as an @Input here and then handle the drop event in the file-upload component as an event handler.

We don't have to in this PR, could always extract it out later. But that would make this drag/drop functionality reusable which would be nice.

Thoughts?

[StevenUlmer]

I went ahead and pulled out al the functionality I could. I had to do some stuff around using class here because just using @HostBinding('class') overwrites all classes already applied to the element

[grahamhency]

We might want to check if @jaredami's PR is going to affect the iconModifer here. #281

[jaredami]

I don't think my PR effects this. However, if I'm not mistaken, while the go-button takes "positive" as an option for its buttonVariant input (and converts it internally to "primary"), the go-icon only accepts "primary" for its iconModifier input, since it has no internal logic which converts "positive" to "primary" and only has a go-icon--primary class, and not a go-icon--positive class.

So I don't think iconModifier="positive" will do anything. You probably want iconModifier="primary", if anything, although all that does it set the color to black, which is probably unnecessary due to inheritance.

[grahamhency]

@jaredami you make a good point here. I think it might make more sense to set the color via a class from the go-file-upload component itself. Thought's @StevenUlmer ?

[StevenUlmer]

Ya that makes sense. I added a class in the go-file-upload component to set the color

[grahamhency]

This binding exists, but it doesn't seem this actually works as intended. Can you take a look at the styling for a dark theme and update them to be correct please?

[grahamhency]

We'll also want documentation for this.

[StevenUlmer]

I fixed the dark theming here and added documentation for it.

[grahamhency]

👍 This looks good to me! We'll see how this goes in practice 😂

I am confident it will work well though 🏆