Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore z index for load screen #270

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Conversation

jaredami
Copy link
Contributor

closes #269

We need to add an additional option to our $z-index function that can be used for loading screens. The new value should be higher than all of the current options to ensure that nothing will appear on top of anything utilizing this option for its z-index.

@grahamhency grahamhency changed the base branch from master to v1.3.0 October 11, 2019 18:56
@grahamhency grahamhency self-requested a review October 11, 2019 18:56
Copy link
Contributor

@grahamhency grahamhency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 👍

@jaredami jaredami added the chore General chore or maintenance task label Oct 14, 2019
@jaredami jaredami merged commit 2668e0a into v1.3.0 Oct 14, 2019
@grahamhency grahamhency deleted the chore_z_index_for_load_screen branch October 14, 2019 14:39
@grahamhency grahamhency added this to the v1.3.0 milestone Oct 14, 2019
@grahamhency grahamhency mentioned this pull request Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore General chore or maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants