Ability to Brand Side Nav and Accordion #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StevenUlmer
force-pushed
the
branding
branch
from
b4f1174 to
7def64d
Compare
deotte
approved these changes
Sep 10, 2019
There was a problem hiding this comment.
My name is Otter and I approve of this PR. @AlexOverbeck @grahamhency
deotte
previously approved these changes
Sep 10, 2019
AlexOverbeck
suggested changes
Sep 11, 2019
StevenUlmer
force-pushed
the
branding
branch
from
7def64d to
9937eba
Compare
StevenUlmer
force-pushed
the
branding
branch
2 times, most recently
from
0283fac to
1d9c1a5
Compare
grahamhency
reviewed
Oct 3, 2019
There was a problem hiding this comment.
@StevenUlmer all of this looks pretty good. What do you think about switching the naming of this to ConfigService? We can then make a GoConfig interface that has various configurations on it. The two I'm thinking right now would be:
- brandColor (which you already have)
- theme
This way, we could expand upon the interface in the future without having to introduce new services for each thing.
|
@StevenUlmer just a couple of other comments on this one.
|
8 tasks
grahamhency
reviewed
Oct 8, 2019
projects/go-lib/src/lib/components/go-side-nav/go-nav-item/go-nav-item.component.ts
Show resolved
Hide resolved
grahamhency
approved these changes
Oct 8, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #158
This adds the ability to brand a couple items in goponents. For now this just includes the 'active' rectangle for both the side nav and the accordion panels. This also removes some unused css from the go-card where branding was being used.
All it takes to brand everything is to import the GoBrandingService into your app.component.ts file and set the brand color through
goBrandingService.setBrandColor(color)